Skip to content

"Dirty" restart enhancements #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
svanoort merged 3 commits into from
Apr 6, 2018
Merged

"Dirty" restart enhancements #101

svanoort merged 3 commits into from
Apr 6, 2018

Conversation

@svanoort
Copy link
Member

@svanoort svanoort commented Apr 5, 2018 •
edited
Loading

  • Switch back to using native file copier utility so it better handles Symlinks and missing files, i.e. tmpFiles that are created by atomic operations and may be deleted while the copy operation is running
  • Added logging for abrupt shutdown processes so you can see what happens while snapshot of JENKINS_HOME is being taken... and what happen after it (activity that can be ignored).
  • Swallows FileNotFoundException

@svanoort svanoort requested review from batmat, jglick and rsandell April 6, 2018 13:20
abayer
abayer approved these changes Apr 6, 2018
View reviewed changes
Copy link
Member

@abayer abayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure? Nothing jumps out at me as a problem, and given how much testing you've been doing, I'm pretty confident you'd've found any gaping holes in this, so, yeah, +1. =)

@batmat
Copy link
Member

batmat commented Apr 6, 2018

As there are no tests here, do you have at least an example somewhere, ideally CI, where you used this successfully?

@svanoort
Copy link
Member Author

svanoort commented Apr 6, 2018

@batmat Yeah it's used heavily in workflow-cps -- I'm using a SNAPSHOT dep here -- jenkinsci/workflow-cps-plugin#216

Most of the issues here couldn't really be tested for because they only crop up in the 'fuzzing' tests which are essentially hammering on the persistence to find race conditions / timing or order of operations issues where durability guarantees break.

@svanoort svanoort merged commit 2df516d into jenkinsci:master Apr 6, 2018
@svanoort svanoort deleted the dirty-restart-enhancements branch April 6, 2018 21:02
@svanoort svanoort mentioned this pull request Apr 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@batmat batmat batmat approved these changes

@jglick jglick Awaiting requested review from jglick

@rsandell rsandell Awaiting requested review from rsandell

+1 more reviewer

@abayer abayer abayer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@svanoort @batmat @abayer